-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[HttpClient] Document new option auto_upgrade_http_version
#21500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
69385bc to
09a6544
Compare
http_client.rst
Outdated
| // ... | ||
|
|
||
|
|
||
| See :ref:`auto_upgrade_http_version <auto-upgrade-http-version>` option for details about how the HTTP protocol version upgrade works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| See :ref:`auto_upgrade_http_version <auto-upgrade-http-version>` option for details about how the HTTP protocol version upgrade works. | |
| See :ref:`auto_upgrade_http_version <auto-upgrade-http-version>` option for details about how the HTTP protocol version selection works. |
http_client.rst
Outdated
|
|
||
| Starting in Symfony 7.4, the option `auto_upgrade_http_version` can | ||
| be set to false to disable automatic HTTP protocol version upgrade when | ||
| possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| possible. | |
| desired. |
|
|
||
| The automatic HTTP version upgrade is always disabled for HTTP/1.0 requests, | ||
| regardless of the option value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest removing this part, I'm not sure it's worth reading/learning
| The automatic HTTP version upgrade is always disabled for HTTP/1.0 requests, | |
| regardless of the option value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to have this documented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @ajgarlag here. I changed this to a note directive. I know HTTP/1.0 is irrelevant these days, but this is an edge-case that can turn into user confusion and frustration if we don't mention it explicitly. Thanks.
09a6544 to
97d1550
Compare
97d1550 to
ac1e0a2
Compare
|
Thanks Antonio! Your contribution was very nice, but we made some rewords/reformatting while merging. Specifically, we don't add contents in |
Fix #21498