chore: add changelog for 4.0.0 #1152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
commented
Sep 8, 2022
| # CHANGELOG | ||
|
|
||
| ## [v4.0.0](https://github.com/symfony/webpack-encore/releases/tag/v4.0.0) | ||
|
|
Member
Author
There was a problem hiding this comment.
The release date is missing
weaverryan
reviewed
Sep 8, 2022
CHANGELOG.md
Outdated
|
|
||
| * The following dependencies **must be added** in your `package.json`: `webpack webpack-cli @babel/core @babel/preset-env` (#1142 and #1150) | ||
| * The following dependencies **must be removed** from your `package.json` and Babel configuration: `@babel/plugin-syntax-dynamic-import @babel/plugin-proposal-class-properties`, | ||
| since they are already included in `@babel/preset-env` (#1150) |
Member
There was a problem hiding this comment.
Unless I'm mistaken, for 99% of users, this will just involve removing this line: https://github.com/symfony/recipes/blob/96d11c2e2ed2a33a796740ed47de0d6d25263fe8/symfony/webpack-encore-bundle/1.10/webpack.config.js#L49
Let's add a diff code block showing that 1 line being removed. I want the upgrade path to be as clear as (A) run this command and (B) remove this line
weaverryan
approved these changes
Sep 9, 2022
Member
|
Thank you Hugo! I'm going to trigger a release next week |
Member
Author
|
Alright perfect :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As asked in #1150 (comment).