Skip to content

Drop ESLint integration #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2024
Merged

Drop ESLint integration #1309

merged 1 commit into from
Aug 30, 2024

Conversation

@Kocal
Copy link
Member

@Kocal Kocal commented Aug 30, 2024 •
edited
Loading

Close #1282, see #1267 (comment) for more information.

Removing Encore.enableEslintPlugin() from user-land. It will ease Encore maintenance a lot!

Users have three options to migrate:

  1. Either re-install eslint-webpack-plugin and add the plugin back through Encore.addPlugin(new EslintPlugin())
  2. Recommended: Either use ESLint in a dedicated task, ex: a git hook pre-commit, a dedicated npm script, a step in their CI, ...
  3. Use alternative (and faster) tools like Biome.js or Oxlint

@Kocal Kocal merged commit 3056c2a into symfony:main Aug 30, 2024
@Kocal Kocal deleted the feat/webpack-encore-1282 branch August 30, 2024 07:49
This was referenced Aug 30, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@alexsegura alexsegura mentioned this pull request May 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop ESLint integration

1 participant

@Kocal