Support CSS modules in Vue.js projects by default #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyrkan
force-pushed
the
vue-css-modules
branch
from
f0756ac to
356e538
Compare
weaverryan
approved these changes
Feb 2, 2019
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Wow! Well-done - very interesting way that this needs to be implemented!
Member
|
Thank you @Lyrkan! |
weaverryan
pushed a commit
that referenced
this pull request
Feb 2, 2019
This PR was merged into the master branch. Discussion ---------- Support CSS modules in Vue.js projects by default With the current version of Encore you are able to either: * only use standard CSS (default behavior) * only use CSS modules (by calling `Encore.configureCssLoader()`) This PR should help detecting when `<style module>` is used and enabling css modules accordingly (fixes #460). **Reference:** https://vue-loader.vuejs.org/guide/css-modules.html#opt-in-usage Commits ------- 356e538 Support CSS modules in Vue.js projects by default
|
Hi! Unfortunately this does not work with a language (scss) set as it used to... Can this support SCSS lang modules too? |
Collaborator
Author
|
Hmm...we probably have to use the same trick for all languages since they re-include the css loader. I'll see what I can do, unless I'm missing something it shouldn't be too hard to implement. |
|
Thank you so much!
…Sent from my iPhone
On Feb 4, 2019, at 11:58 PM, Vincent Le Biannic ***@***.***> wrote:
Hmm...we probably have to use the same trick for all languages since they re-include the css loader. I'll se what I can do, unless I'm missing something it shouldn't be too hard to implement.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
weaverryan
added a commit
that referenced
this pull request
Mar 1, 2019
…Lyrkan) This PR was merged into the master branch. Discussion ---------- Add CSS modules support in Vue.js for Sass/Less/Stylus As noted in #508 (comment), that previous PR actually only added support for standard CSS modules, but didn't work for other languages. This new PR makes it so it also works with the Scss, Less and Stylus syntaxes (using the same principle). Ping @Chesskingt :) Commits ------- 3224e6c Add CSS modules support in Vue.js for Sass/Less/Stylus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current version of Encore you are able to either:
Encore.configureCssLoader())This PR should help detecting when
<style module>is used and enabling css modules accordingly (fixes #460).Reference: https://vue-loader.vuejs.org/guide/css-modules.html#opt-in-usage