Skip to content

Conversation

ripienaar
Copy link
Contributor

Because we're returning from an embedded type go
will never consider this result as nil from
the caller.

Handle it here and return actual nil

Because we're returning from an embedded type go
will never consider this result as nil from
the caller.

Handle it here and return actual nil

Signed-off-by: R.I.Pienaar <[email protected]>
@ripienaar ripienaar requested a review from aricart February 7, 2024 14:51
Copy link
Collaborator

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ripienaar ripienaar merged commit 8bc06b1 into synadia-io:main Feb 7, 2024
@ripienaar ripienaar deleted the nil_isnt_nil branch February 7, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants