feat(alerts): introduce duration attribute #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbonf
force-pushed
the
alerts-new-api-fields
branch
2 times, most recently
from
79c16f1 to
f0a6ce7
Compare
dbonf
force-pushed
the
alerts-new-api-fields
branch
from
f0a6ce7 to
faa1a77
Compare
dbonf
force-pushed
the
alerts-new-api-fields
branch
from
faa1a77 to
3436aa2
Compare
dbonf
requested review from
michelevergnano,
dkutsanov and
antonio-cuomo
as code owners
michelevergnano
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
duration_secondsattribute on v2 alerts that support ittrigger_after_minutesin favour of the newrange_seconds(orduration_secondsin case of prometheus alerts) in order to avoid confusion with the new duration attribute