fix(cloudauth): remove 404 error swallow #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ravinadhruve10 within the constraints of this older terraform testing framework, I'm not certain this best approach to apply tests for this behavior. any thoughts? |
Sorry, not sure I follow. Are we asking if the current ACC tests we have are testing all the possible behaviors or not? (the ones in question particularly) |
ravinadhruve10
approved these changes
Jul 17, 2024
These errors should not be swallowed. they are legitimate and should be bubbled up. Leaving the 404 swallow for the delete case since it also represents success on a delete operation
cgeers
force-pushed
the
fix/cloudauth/remove_404_swallow
branch
from
2405edd to
fb2769b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These errors should not be swallowed. they are legitimate and should be bubbled up. Leaving the 404 swallow for the delete case since it also represents success on a delete operation