feat(event-bridge): add cloudingestion event-bridge webhook (SSPROD-53947) #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteopasa
requested review from
filiptubic,
mbarbieri and
draraksysdig
as code owners
matteopasa
force-pushed
the
pasa/api-dest/update-cling-assets-call
branch
from
72bed50 to
c4b5b43
Compare
matteopasa
force-pushed
the
pasa/api-dest/update-cling-assets-call
branch
from
803de43 to
80ccd5f
Compare
lorenzo-merici
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the
sysdigpackage, particularly focusing on enhancing the cloud ingestion assets functionality. The changes introduce a newcomponent_typeattribute, update the logic for retrieving cloud ingestion assets, and add new test cases to ensure the correct implementation.Enhancements to Cloud Ingestion Assets:
component_typeattribute todataSourceSysdigSecureCloudIngestionAssetsto support different component types. (sysdig/data_source_sysdig_secure_onboarding.go)dataSourceSysdigSecureCloudIngestionAssetsReadfunction to handle different cloud providers (GCP and AWS) and component types. (sysdig/data_source_sysdig_secure_onboarding.go) [1] [2]Test Updates:
component_typeattribute for AWS EventBridge. (sysdig/data_source_sysdig_secure_onboarding_test.go)Internal Client Updates:
onboardingCloudIngestionAssetsPathto includecomponentTypeas a query parameter. (sysdig/internal/client/v2/onboarding.go)GetCloudIngestionAssetsSecuremethod to acceptcomponentTypeas an additional parameter. (sysdig/internal/client/v2/onboarding.go)