Skip to content

fix(posture/accept-risk): allow expires_in=Never value #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

fix(posture/accept-risk): allow expires_in=Never value #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sysdig/resource_sysdig_secure_accept_posture_risk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func resourceSysdigSecureAcceptPostureControlCreate(ctx context.Context, d *sche
t := d.Get(SchemaEndTimeKey).(string)
endTime, _ = strconv.ParseInt(t, 10, 64)
}
if endTime <= time.Now().UTC().UnixMilli() {
if endTime > 0 && endTime <= time.Now().UTC().UnixMilli() {
return diag.Errorf("Error creating accept risk. error status: %s err: %s", "ExpiresAt must be in the future", fmt.Errorf("ExpiresAt must be in the future"))
}
req.ExpiresAt = strconv.FormatInt(endTime, 10)
Expand Down
14 changes: 14 additions & 0 deletions sysdig/resource_sysdig_secure_accept_posture_risk_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ func TestAcceptSecurePostureRisk(t *testing.T) {
},
},
Steps: []resource.TestStep{
{
Config: acceptPostureRiskWithoutExpirationDate(),
},
{
Config: acceptPostureRiskResource(),
},
Expand Down Expand Up @@ -50,3 +53,14 @@ resource "sysdig_secure_posture_accept_risk" "accept_resource" {
filter = "name in ('system:controller:daemon-set-s') and kind in ('ClusterRole')"
}`
}

func acceptPostureRiskWithoutExpirationDate() string {
return `
resource "sysdig_secure_posture_accept_risk" "accept_resource" {
description = "test accept posture risk resource"
control_name = "ServiceAccounts with cluster access"
reason = "Risk Transferred"
expires_in = "Never"
filter = "name in ('system:controller:daemon-set-s') and kind in ('ClusterRole')"
}`
}
Loading