OpenStreetMap attributions

[albanm]

As far as I can see the metadata generated by tilemaker does not include attribution info.

It is always possible to add this afterwards or on the client side. But the result is that a "by default" approach of using tilemaker + maplibre for example results in not following the openstreetmap and openmaptiles requirements.

Should not the attribution be included as expected by the specs ?

[systemed]

Interesting question! If (say) Maplibre JS displays the attribution metadata by default then, yes, we should - I hadn't realised it does that. It should just be a matter of adding the relevant line to "settings" -> "metadata" in config-openmaptiles.json, I think.

[albanm]

Maplibre uses the attribution contained in the tileset metadata automatically (https://github.com/maplibre/maplibre-gl-js/blob/87486a5ef2085e600e8fa4e31252629dd8488dcd/src/ui/control/attribution_control.ts#L151). And the attributionControl option is active by default.

[systemed]

That's great. I'd be very happy to receive a PR for this or failing that I'll look at it when I get the proverbial spare minute.