feat: optionally find population from relations #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the way the
populationattribute is fetched for places. If it can't find a population on the place itself, it will attempt to read the relations until it finds a label that does contain a population.I noticed that some city centers in my area of Germany did not contain the population on the city center node, but on the administrative boundary. While I added the population to the labels on the ones I saw missing, I figure it might be a common issue, so the processing script should optionally handle it as well.
Example:
Boundary: https://www.openstreetmap.org/relation/454863#map=13/50.56452/9.64956
Node (prior to me adding the population): https://www.openstreetmap.org/node/240088844/history/59