fix a number of bugs and differences from openmaptiles vector tile schema #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hema 1. zoom 4, 5, and 7 road values were incorrectly being used. 2. openmaptiles shows admin 3 boundaries much higher. 3. unpaved and paved values are parsed from surface list 4. remove duplicate variable definitions. 5. SetMinZoomByAreaWithLimit allows up to minzoom 4 6. fix whitespace and a few variable issues.
|
M393
reviewed
Sep 18, 2025
Comment on lines
+842
to
+847
| if minzoom <= 1 and area>ZRES0^2 then MinZoom(1) | ||
| elseif minzoom <= 2 and area>ZRES1^2 then MinZoom(2) | ||
| elseif minzoom <= 3 and area>ZRES2^2 then MinZoom(3) | ||
| elseif minzoom <= 4 and area>ZRES3^2 then MinZoom(4) | ||
| elseif minzoom <= 5 and area>ZRES4^2 then MinZoom(5) | ||
| elseif minzoom <= 6 and area>ZRES5^2 then MinZoom(6) |
There was a problem hiding this comment.
- SetMinZoomByAreaWithLimit allows up to minzoom 4
I'm curious why does this only allow up to minzoom 4?
I'm trying to show lakes on all zoom levels. With this change they do now show up on zoom level 4 and 5, but not earlier.
E.g. https://www.openstreetmap.org/relation/945096
My config:
"water": { "minzoom": 0, "maxzoom": 14, "simplify_below": 12, "simplify_level": 0.0003, "simplify_ratio": 2}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zoom 4, 5, and 7 road values were incorrectly being used.
openmaptiles shows admin 3 boundaries much higher.
unpaved and paved values are parsed from surface list
remove duplicate variable definitions.
SetMinZoomByAreaWithLimit allows up to minzoom 4
fix whitespace and a few variable issues.