Use absolute as the default Floating UI strategy
#3097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done for 2 reasons: 1. The default strategy in Floating UI was already `absolute` 2. It can improve performance drastically when using transitions The main reason we used `fixed` was to ensure that it wasn't accidentally positioned to another `relative` element. However, all components that use this `FloatingProvider` will also use a portal which puts elements in the `<body>` already so this should be safe. If it is not safe for your application, then you can still use the `fixed` strategy.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
reinink
approved these changes
Apr 15, 2024
This was referenced May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done for 2 reasons:
absoluteThe main reason we used
fixedwas to ensure that it wasn't accidentally positioned to anotherrelativeelement. However, all components that use thisFloatingProviderwill also use a portal which puts elements in the<body>already so this should be safe.If it is not safe for your application, then you can still use the
fixedstrategy.