Neighbor root histories #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nonce is now updated upon and emmited upon anchor deposit
…into integration-tests
Co-authored-by: drewstone <[email protected]>
Co-authored-by: drewstone <[email protected]>
…into integration-tests
…tocol-solidity into integration-tests
nepoche
reviewed
Aug 11, 2021
nepoche
reviewed
Aug 11, 2021
kmadk
commented
Aug 11, 2021
Comment on lines
+175
to
+176
| // insert two commitments into the tree | ||
| await tree.insert(firstOriginDeposit.commitment); |
Co-authored-by: nepoche <[email protected]>
drewstone
requested changes
Aug 11, 2021
Contributor
drewstone
left a comment
drewstone
left a comment
There was a problem hiding this comment.
Looks good but not exactly how we discussed it. The roots passed into the contract should be a string of bytes arbitrarily. We will parse it into the size we expect and so on and so forth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.