Skip to content

Conversation

@drewstone
Copy link
Contributor

No description provided.

@drewstone drewstone requested review from kmadk and nepoche August 25, 2021 23:49
Copy link
Contributor

@kmadk kmadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nepoche
Copy link
Contributor

nepoche commented Aug 27, 2021

Remind me of the purpose of the BridgeFactory? I thought it was to be able to deploy to new networks through GovBravo directly. This seems like this enables that, so LGTM.

Copy link
Contributor

@kmadk kmadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end

@kmadk
Copy link
Contributor

kmadk commented Aug 27, 2021

Remind me of the purpose of the BridgeFactory? I thought it was to be able to deploy to new networks through GovBravo directly. This seems like this enables that, so LGTM.

I think the plan is for us (Webb) or some other member of the community to deploy these factories and then the GovBravo on that chain will use them to deploy the anchors themselves.

@drewstone drewstone merged commit 452d3d5 into main Aug 30, 2021
@drewstone drewstone deleted the drew-factories branch November 3, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants