Change height to leaf index in Solidity and tests #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akileshtangella
approved these changes
Oct 6, 2021
Contributor
akileshtangella
left a comment
akileshtangella
left a comment
There was a problem hiding this comment.
Changes look good. All tests are passing locally on my machine, as well.
nepoche
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes a value on every edge from the block height to the latest leaf index processed from that edge.
Motivation
The motivation is that we can easily see the latest leaf index that a bridged chain knows about before making a withdrawal / zkp generation. That way, we can provide more clarity to the user of whether their note is ready for spending across chains.