Webb-Solidity package structure #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest published npm
- @nepoche/[email protected] - @nepoche/[email protected] - @nepoche/[email protected] - @nepoche/[email protected] - [email protected]
- @nepoche/[email protected] - @nepoche/[email protected] - @nepoche/[email protected] - @nepoche/[email protected] - [email protected]
nepoche
commented
Nov 27, 2021
nepoche
requested review from
akileshtangella and
drewstone
and removed request for
drewstone
Contributor
|
Awesome work, first glance is # of files / lines changed is huge. Maybe we're committing something we shouldn't be. Phone isn't loading commits easily.. EDIT: Looks like mostly TS type files. I presume we're not using a large majority of them for anything. We should remove and try to shrink the size of these types, isolating them as much as possible if not already done. Wdyt? |
- @nepoche/[email protected] - @nepoche/[email protected] - @nepoche/[email protected] - [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the project structure to separate packages:
This PR brings in a dependency on
lernafor building and publishing the packages.This PR updates the root-directory package.json to include:
yarn build:packages- needs to be run before tests.yarn compile- should be run instead ofnpx hardhat compileas it will run a script to update the src files in the contracts directory of the latest typechain output.