Skip to content

Filter out namespaced internal modules #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Filter out namespaced internal modules #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ const natives = [].concat(
require('module').builtinModules,
'bootstrap_node',
'node',
).map(n => new RegExp(`(?:\\(${n}\\.js:\\d+:\\d+\\)$|^\\s*at ${n}\\.js:\\d+:\\d+$)`));
).map(n => new RegExp(`(?:\\((?:node:)?${n}(?:\\.js)?:\\d+:\\d+\\)$|^\\s*at (?:node:)?${n}(?:\\.js)?:\\d+:\\d+$)`));

natives.push(
/\(internal\/[^:]+:\d+:\d+\)$/,
/\s*at internal\/[^:]+:\d+:\d+$/,
/\((?:node:)?internal\/[^:]+:\d+:\d+\)$/,
/\s*at (?:node:)?internal\/[^:]+:\d+:\d+$/,
/\/\.node-spawn-wrap-\w+-\w+\/node:\d+:\d+\)?$/
);

Expand Down
42 changes: 42 additions & 0 deletions test/internals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
'use strict';

const t = require('tap');
const StackUtils = require('../');

const utils = require('./_utils');

const stackUtils = new StackUtils({ cwd: '/home/user' });

t.test('removes namespaced internal modules', t => {
const stack = utils.join([
'at Test.<anonymous> (test/test.js:99:5)',
'at TapWrap.runInAsyncScope (node:async_hooks:193:9)',
'at Object.<anonymous> (test/test.js:94:3)',
'at Module._compile (node:internal/modules/cjs/loader:1083:30)',
'at Module.replacementCompile (node_modules/append-transform/index.js:58:13)',
'at Module._extensions..js (node:internal/modules/cjs/loader:1112:10)',
'at Object.<anonymous> (node_modules/append-transform/index.js:62:4)',
'at Module.load (node:internal/modules/cjs/loader:948:32)',
'at Function.Module._load (node:internal/modules/cjs/loader:789:14)',
'at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:72:12)',
'at Module._compile (node:internal/modules/cjs/loader:1083:30)',
'at Object.Module._extensions..js (node:internal/modules/cjs/loader:1112:10)',
'at Module.load (node:internal/modules/cjs/loader:948:32)',
'at Function.Module._load (node:internal/modules/cjs/loader:789:14)',
'at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:72:12)',
'at Module._compile (node:internal/modules/cjs/loader:1083:30)',
'at Object.Module._extensions..js (node:internal/modules/cjs/loader:1112:10)',
'at Module.load (node:internal/modules/cjs/loader:948:32)',
'at Function.Module._load (node:internal/modules/cjs/loader:789:14)',
'at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:72:12)',
'at node:internal/main/run_main_module:17:47'
]);
const expectedStack = utils.join([
'Test.<anonymous> (test/test.js:99:5)',
'Object.<anonymous> (test/test.js:94:3)',
'Module.replacementCompile (node_modules/append-transform/index.js:58:13)',
'Object.<anonymous> (node_modules/append-transform/index.js:62:4)',
])
t.plan(1);
t.is(stackUtils.clean(stack), expectedStack);
});