Add module version constant #289
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| `VERSION` - is a crud module version constant. | ||
|
|
||
| Use `crud.VERSION` on "routers" to get module version, or `_crud.VERSION` - on storages. |
There was a problem hiding this comment.
Why we use globals and different API for routers and storages? There are no supported cases for using _crud now, all interaction are processed with require('crud').something
There was a problem hiding this comment.
It's internal and should be used only by crud itself, not by user
|
Closed by #342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add crud.VERSION (_crud.VERSION) constant to make possible to determine module version in runtime.
I didn't forget about
Closes #240