-
-
Notifications
You must be signed in to change notification settings - Fork 91
feat: add TaskiqAdminMiddleware and aiohttp package #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
spikeninja
commented
Jun 29, 2025
- add TaskiqAdminMiddleware to middlewares
- add aiohttp package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this will work as you intended.
I think it would be better to make all method implementations asynchronous to ensure that the loop is running. While we are pretty much confident that it should execute correctly, it might be somewhat controversial for users who want to test this middleware or use it manually for some reason.
Since TaskiqMiddleware
allows you to define both synchronous and asynchronous methods, you can achieve this by simply adding the async
keyword right before the def
.
What do you think? Does this make sense to you?
Thanks for #478! |
Hey @smalyu Yes, I would like to add it but as a separate middleware, smth like TaskqAdminBrokerMiddleware Let me firstly finish refining the http one pls and we can jump into the broker one) |
65597e2
to
448624f
Compare
@s3rius Review it pls |