Fix CalendarDateArithmeticYear and make it take an ISO Date Record #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Jul 25, 2025
ryzokuken
approved these changes
Jul 26, 2025
There was a problem hiding this comment.
LGTM, but remember to build the spec and add the biblio entry for https://tc39.es/proposal-temporal/#sec-temporal-iso-date-records
sffc
force-pushed
the
refactor-CalendarDateArithmeticYear
branch
from
5e81cfa to
841e187
Compare
|
The following line is already in biblio.json: {
"type": "term",
"term": "ISO Date Record",
"id": "sec-temporal-iso-date-records"
}, |
|
I'm going to merge based on @ryzokuken's approval in order to prevent bitrot. If @ptomato sees anything else, I'll fix in a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small bug I noticed today.
The current text doesn't work when there are two new calendar years in the same ISO year, which can happen in Hijri, for example.
I also made the AO take an
ISO Date Recordso that I can use it in some of the other AOs I'm writing.