Skip to content

Conversation

darludi58
Copy link

for (int i = 0; i < SHA256::DIGEST_SIZE; i++)
change to
for (int i = 0; i < (int) SHA256::DIGEST_SIZE; i++)

  for (int i = 0; i < SHA256::DIGEST_SIZE; i++)
change to
  for (int i = 0; i < (int) SHA256::DIGEST_SIZE; i++)
@knasher
Copy link
Member

knasher commented Jan 12, 2019

Thanks for your PR, I didn't write the sha256.cpp file (as explained in my blog post) but I've taken a look and DIGEST_SIZE is already defined as an int, what benefit would there be from casting it to an int again?

@subhutrivedi
Copy link

After successful compilation, i am only gettinh the output as:-
Mining 1...

after that it doesn't display anything.
What could be the reason??
Please help me out to get the desired output.

@AngelBravoS
Copy link

it seems that the @subhutrivedi update just makes the warning

"comparison between signed and unsigned integer expressions [-Wsign-compare]"

disappear with no further consequences.

After successful compilation, i am only gettinh the output as:-
Mining 1...

after that it doesn't display anything.
What could be the reason??
Please help me out to get the desired output.

@subhutrivedi, have you ever tried to change the _nDifficulty = 6; from the blockchain constructor to a lower value?

@subhutrivedi
Copy link

subhutrivedi commented Jul 12, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants