Skip to content

Evolve documentation of update polling parameters #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Evolve documentation of update polling parameters #406

wants to merge 2 commits into from

Conversation

dandavison
Copy link
Contributor

No description provided.

@dandavison dandavison requested review from a team as code owners May 20, 2024 14:27
@dandavison dandavison force-pushed the update-polling-edits branch from a732611 to ccb8b29 Compare May 20, 2024 14:39
yiminc
yiminc reviewed May 20, 2024
View reviewed changes
Sushisource
Sushisource approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool if you could update the variants in the enum too to specify what they mean as a request (already exists) and what they mean as a return value (which I don't think they say, and would be nice to have).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiminc yiminc yiminc left review comments

@cretz cretz cretz approved these changes

@Sushisource Sushisource Sushisource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dandavison @cretz @Sushisource @yiminc