Add support for activity reset #2546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Jun 5, 2025
Member
There was a problem hiding this comment.
With some other SDKs, we have also provided a way to activities to see all states that may affect cancellation even though only one is thrown. We call it "cancellation details". I wonder if we should provide something like that in Java on the activity context (so they can see bools for cancel requested, paused, reset, etc).
Contributor
Author
There was a problem hiding this comment.
Yes, we should there is a separate issue for this
cretz
approved these changes
Jun 9, 2025
THardy98
reviewed
Jun 18, 2025
Contributor
THardy98
left a comment
THardy98
left a comment
There was a problem hiding this comment.
left some thoughts on priority/ordering between pause and reset
...k/src/main/java/io/temporal/internal/client/external/ManualActivityCompletionClientImpl.java
Outdated
Show resolved
Hide resolved
...k/src/main/java/io/temporal/internal/client/external/ManualActivityCompletionClientImpl.java
Outdated
Show resolved
Hide resolved
temporal-sdk/src/main/java/io/temporal/internal/activity/HeartbeatContextImpl.java
Show resolved
Hide resolved
temporal-sdk/src/test/java/io/temporal/activity/ActivityResetTest.java
Outdated
Show resolved
Hide resolved
Quinn-With-Two-Ns
force-pushed
the
issue-2488
branch
from
34710cd to
6db0e46
Compare
Quinn-With-Two-Ns
force-pushed
the
issue-2488
branch
from
6db0e46 to
fed86aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for activity reset
closes #2488