💥 Replayer configuration from plugins #1011
Conversation
tconley1428
changed the title
Co-authored-by: Spencer Judge <[email protected]>
tconley1428
changed the title
|
|
||
| def configure_replayer(self, config: ReplayerConfig) -> ReplayerConfig: | ||
| """Configure the replayer for OpenAI Agents.""" | ||
| config["interceptors"] = list(config.get("interceptors") or []) + [ |
There was a problem hiding this comment.
This seems like a very surprising footgun and introduces coupling, and requires that users understand a concept (Replayer) that few are familiar with. It feels like a very large chance that users will mess this up.
There was a problem hiding this comment.
This is why we chose to require that plugin authors configure replayers and therefore become familiar with them. Regular users don't need to become familiar with replayers, but plugin authors do to ensure their plugin works right in replayer scenarios and not just client and worker scenarios.
| config["data_converter"] = pydantic_data_converter | ||
| return config | ||
|
|
||
| async def run_replayer( |
There was a problem hiding this comment.
@tconley1428 This async shouldn't be here
|
|
||
| def configure_replayer(self, config: ReplayerConfig) -> ReplayerConfig: | ||
| config["data_converter"] = pydantic_data_converter | ||
| return config |
There was a problem hiding this comment.
@tconley1428 This should call self.next_worker_plugin.configure_replayer right?
* POC for replayer configuration from existing plugins * Handle non-combined cases * Fixing type checking * Move shared configuration into plugin definition * Moving replay configuration to worker plugin, add replay execution hook * Readme and some cleanup * Remove debug logging * Make plugin interface experimental and abstract * Update readme * Update readme * Readme fixes, move plugin to its own file * Fix readme * Update temporalio/worker/_plugin.py Co-authored-by: Spencer Judge <[email protected]> * Rename run_replayer, remove need to return self from init * Docstring change --------- Co-authored-by: Spencer Judge <[email protected]>
5 participants
What was changed
Added ability to configure replayer to plugins. Plugins as a whole have become abstract so that plugin authors need to consider the different components they may need to configure.
Why?
Checklist
Closes [Feature Request] Worker plugin support for replayers #994
How was this tested: