Skip to content

Conversation

THardy98
Copy link
Contributor

What was changed

Remove check for address in config. Allows for users to call to_client_connect_config and override this value themselves. The Client.connect call already does this validation for us.

Makes it easy in the general case where users just want to do:

config = ClientConfig.load_client_connect_config()
config.setdefault("target_host", "localhost:7233")
Client.connect(**config)
  1. How was this tested:
    No tests

  2. Any docs updates needed?
    No

@THardy98 THardy98 requested a review from a team as a code owner August 15, 2025 19:51
@THardy98 THardy98 merged commit e9d8c1a into main Aug 15, 2025
26 of 28 checks passed
@THardy98 THardy98 deleted the revert_envconfig_address_check branch August 15, 2025 23:19
tconley1428 pushed a commit that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants