Don't add startActivity, etc spans when there is no parent trace in which to nest them #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hich to nest them
tconley1428
commented
Aug 19, 2025
cretz
reviewed
Aug 20, 2025
cretz
approved these changes
Aug 20, 2025
tconley1428
added a commit
that referenced
this pull request
Aug 28, 2025
…hich to nest them (#1037) * Don't add startActivity, etc spans when there is no parent trace in which to nest them * Type ignore instead of recheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Title
Why?
When the spans are created, they produce annoying warning messages since there is no trace to which to send them. Would welcome feedback on doing this with less duplication. My attempt at a decorator got gnarly enough I wasn't sure it was worthwhile.
Checklist
Closes
How was this tested:
Validated the changes against https://github.com/temporal-sa/oai-temporal-wealth-management/tree/modify_ux
Any docs updates needed?