Fix code sample alignment #1038
Merged
+34
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconley1428
approved these changes
Aug 21, 2025
dandavison
force-pushed
the
dan-9993-readme-plugins
branch
from
87a845f to
999e0a7
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| def run_replayer( | ||
|
|
||
| async def run_replayer( |
There was a problem hiding this comment.
Bug: Async Method Returns Coroutine Instead of Context Manager
The UnifiedPlugin.run_replayer method was changed from def to async def. This makes the method return a coroutine, but it should directly return an AbstractAsyncContextManager by delegating to the next plugin. This change breaks the API contract, as callers would now need to await the method before using the context manager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix code alignment in plugins README documentation.
Trim trailing whitespace.