Skip to content

Conversation

dandavison
Copy link
Contributor

  • Support multiple nexus callers attaching to same workflow
  • This requires setting the fields in on_conflict_options to true so that, when the nexus op "attaches" to a running workflow, a "request ID reference" outbound link is constructed, and the callback is appended to the existing callbacks, and the inbound links are attached to the created event.
  • The server only honors on_conflict_options when conflict_policy=UseExisting, so Python passes them unconditionally, as do Go and Java.
  • They must be set for the nexus-backing workflow only; not for any other workflow that might be started by the nexus start handler. The PR uses a context var to achieve that.

@dandavison dandavison requested a review from a team as a code owner August 25, 2025 16:54
@dandavison dandavison force-pushed the dan-9995-nexus-callers-attach-to-same-workflow branch 2 times, most recently from 1d27dff to 9cf5f49 Compare August 25, 2025 17:02
@dandavison dandavison force-pushed the dan-9995-nexus-callers-attach-to-same-workflow branch from 9cf5f49 to cd4dc9e Compare August 25, 2025 17:04
@dandavison dandavison force-pushed the dan-9995-nexus-callers-attach-to-same-workflow branch from cd4dc9e to f3cf5ee Compare August 25, 2025 17:35
cursor[bot]

This comment was marked as outdated.

@dandavison dandavison merged commit a9c71aa into main Aug 25, 2025
28 of 29 checks passed
@dandavison dandavison deleted the dan-9995-nexus-callers-attach-to-same-workflow branch August 25, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants