Added retry policy to activity info #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejdudko
force-pushed
the
activity-info-retry-policy
branch
3 times, most recently
from
d6f588f to
dc8a3d1
Compare
dandavison
reviewed
Aug 28, 2025
| workflow_run_id: str | ||
| workflow_type: str | ||
| priority: temporalio.common.Priority | ||
| retry_policy: Optional[temporalio.common.RetryPolicy] |
There was a problem hiding this comment.
How about adding a docstring here explaining that None means that it has a server-defined default retry policy (does not mean it does not retry).
Although we don't yet have docstrings on activity.Info, we do on workflow.Info, so I think it makes sense to start adding them on activity.Info.
dandavison
approved these changes
Aug 28, 2025
maciejdudko
force-pushed
the
activity-info-retry-policy
branch
from
dc8a3d1 to
51c23da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added retry policy to activity info.
Why?
Feature request: temporalio/features#615
Checklist
Closes [Feature Request] Show retry policy on activity info #831
How was this tested:
Added assertion to
tests/worker/test_activity.py::test_activity_info