Skip to content

Conversation

dandavison
Copy link
Contributor

@dandavison dandavison commented Aug 27, 2025

Fix races in nexus cancellation tests.

I have not repro'd the failures on my MacOS laptop; this PR was tested by modifing CI to run cancellation types tests 10 times.

  • Move a future out of the global struct into a workflow; exposed via an update
  • Stop making assertions about CANCEL_REQUEST_{COMPLETED,FAILED} under TRY_CANCEL since in that case the timing of these events (which are triggered by cancel handler returning) races with the timing of the events triggered by the handler workflow exiting as canceled.
  • Use workflow.now() instead of recording clock time in the workflow.

@dandavison dandavison force-pushed the dan-9991-fix-nexus-cancellation-type-test-flake branch 2 times, most recently from 9ad998f to 6abdbb6 Compare August 27, 2025 14:30
@dandavison dandavison marked this pull request as ready for review August 27, 2025 17:45
@dandavison dandavison requested a review from a team as a code owner August 27, 2025 17:45
@dandavison dandavison requested a review from tconley1428 August 27, 2025 18:49
@dandavison dandavison force-pushed the dan-9991-fix-nexus-cancellation-type-test-flake branch from bbc0be4 to 421e2d8 Compare August 27, 2025 19:18
@dandavison dandavison enabled auto-merge (squash) August 27, 2025 19:19
@dandavison dandavison force-pushed the dan-9991-fix-nexus-cancellation-type-test-flake branch from 421e2d8 to 3c1f431 Compare September 2, 2025 17:24
@dandavison dandavison disabled auto-merge September 2, 2025 17:28
@tconley1428 tconley1428 merged commit 251084d into main Sep 2, 2025
5 of 17 checks passed
@tconley1428 tconley1428 deleted the dan-9991-fix-nexus-cancellation-type-test-flake branch September 2, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants