Fix nexus cancellation type test flake #1057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix races in nexus cancellation tests.
I have not repro'd the failures on my MacOS laptop; this PR was tested by modifing CI to run cancellation types tests 10 times.
CANCEL_REQUEST_{COMPLETED,FAILED}
underTRY_CANCEL
since in that case the timing of these events (which are triggered by cancel handler returning) races with the timing of the events triggered by the handler workflow exiting as canceled.workflow.now()
instead of recording clock time in the workflow.