Skip to content

Conversation

dandavison
Copy link
Contributor

@dandavison dandavison commented Sep 2, 2025

Fix more flakiness in nexus cancellation tests:

  • Use <= instead of < for within-workflow event time comparisons
  • Do not make assertions about cross-workflow event ordering

Both cases were relying on a strict less-than relation on event times, which we do not have, even within a single server binary and in the absence of buffered events, due to coarse system time granularity on Windows.

@dandavison dandavison force-pushed the fix-nexus-cancellation-wait-completed-test branch from e289fab to ff0881b Compare September 3, 2025 19:52
@dandavison dandavison marked this pull request as ready for review September 3, 2025 20:09
@dandavison dandavison requested a review from a team as a code owner September 3, 2025 20:09
@dandavison dandavison force-pushed the fix-nexus-cancellation-wait-completed-test branch from a43d47c to 0fc0ab6 Compare September 3, 2025 20:10
Copy link
Contributor

@tconley1428 tconley1428 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not following 100%, but it still seems like it relies on some amount of time ordering. Happy to take an incremental improvement even if it isn't perfect though.

@dandavison
Copy link
Contributor Author

still seems like it relies on some amount of time ordering ... an incremental improvement ...

Yes that's accurate. I believe that most/all of the remaining time comparison logic here is valid, it's just that Windows was making some timestamps surprisingly be equal. The >= changes will handle that without loss of assertion stringency.

Meanwhile, the sorting of events from different workflows had to be thrown out because Windows was introducing ties which were fundamentally incompatible with the assertions that were being attempted.

@dandavison dandavison merged commit 70e5bea into main Sep 4, 2025
49 of 53 checks passed
@dandavison dandavison deleted the fix-nexus-cancellation-wait-completed-test branch September 4, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants