Skip to content

Conversation

afitz0
Copy link
Contributor

@afitz0 afitz0 commented Aug 22, 2022

What was changed

In README.md correct a placeholder package name to the correct name used in the example.

Why?

So that copy-pasting the example runs correctly, without modifications.

Checklist

How was this tested:

  • Installed python sdk.
  • Ran quickstart example, making no additional modifications to the code.
  • Witness Result: Hello, my name! as expected.

@CLAassistant
Copy link

CLAassistant commented Aug 22, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting people to have their workflows somewhere else, but this makes sense for a quick start. Arguably it could be .run_worker. For best practices of course, you probably wouldn't put your workflow in the worker's main script.

@cretz cretz merged commit 4db14cc into temporalio:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants