Update and dogfood test framework #132
Conversation
cretz
force-pushed
the
test-server-update
branch
from
9a54b2e to
bcbe4fa
Compare
| interceptors.append(_TimeSkippingClientInterceptor(self)) | ||
| super().__init__(_client_with_interceptors(client, *interceptors)) | ||
| self._server = server | ||
| self._auto_time_skipping = True |
There was a problem hiding this comment.
nit: It reads a bit funny that this always is initted to true even if skipping is unsupported.
There was a problem hiding this comment.
Agreed, but luckily internal only. I can clarify in a comment this has no meaning when time skipping unsupported.
| logger = logging.getLogger(__name__) | ||
|
|
||
| # TODO(cretz): Remove this when Temporalite supports search attributes and TLS | ||
| class ExternalGolangServer: |
There was a problem hiding this comment.
Why call this a GolangServer? Maybe just LocalSrcServer or something? Temporalite is a "golang" server too, they all are really, so it doesn't draw much distinction
Or maybe even GoBuildServer
There was a problem hiding this comment.
This is what it was called before, I just moved it from another file. And it's a "golang" server in that it is the only reason I have to have Go in the Python repository and I literally go-build it live whereas Temporalite could be written in anything.
The goal is to delete this, I just have to get some features into Temporalite first which are gonna have to wait on server 1.18 for dynamic config cleanup.
|
I am currently "debugging in CI" a problem that only happens on non-windows Python 3.7. There is something with the event loop implementation on this older version that is clashing with the test implementation. |
cretz
force-pushed
the
test-server-update
branch
4 times, most recently
from
a75b040 to
ed4bd4e
Compare
|
Ok, CI fixed in core and upgraded here. |
| non_retryable_error_types: Optional[Sequence[str]] = None | ||
|
|
||
|
|
||
| @workflow.defn(name="kitchen_sink") |
There was a problem hiding this comment.
Are you keeping this kitchen sink workflow around long term?
There was a problem hiding this comment.
Not sure yet. It powers client and activity tests since those were written prior to workflows even being available. It's pretty small for what it does.
| @@ -0,0 +1,151 @@ | |||
| use pyo3::exceptions::{PyRuntimeError, PyValueError}; | |||
There was a problem hiding this comment.
This is so much nicer with pyo3 than neon :(
| ) | ||
|
|
||
| @staticmethod | ||
| async def start_local( |
There was a problem hiding this comment.
Nice work on this, I'll copy more of it over to TS
3 participants
What was changed
Checklist