Add sdk-features CI trigger #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
force-pushed
the
sdk-features-ci
branch
from
cbeabc5 to
048ed65
Compare
Sushisource
force-pushed
the
sdk-features-ci
branch
from
048ed65 to
abb2fec
Compare
cretz
approved these changes
Nov 18, 2022
|
|
||
| # Runs the sdk features repo tests with this repo's current SDK code | ||
| sdk-features-tests: | ||
| uses: temporalio/sdk-features/.github/workflows/python.yaml@main |
There was a problem hiding this comment.
So I assume that, if I have breaking changes that would break SDK features, I would point to a branch on there until I release the SDK?
There was a problem hiding this comment.
That's definitely the most obvious solution for now. If this turns out to be a repeated pain, perhaps we design something easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on temporalio/features#162