Skip to content

Update SDK core and minor updates #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 5, 2022
Merged

Update SDK core and minor updates #221

merged 5 commits into from
Dec 5, 2022

Conversation

@cretz
Copy link
Member

@cretz cretz commented Dec 5, 2022 •
edited
Loading

What was changed

  • Update SDK core
  • Remove cross-namespace child workflow calls (💥 - technically backwards incompatible, though unlikely ever used)
  • Stop generating unnecessary _grpc.py and _grpc.pyi files for non-service packages
  • Add grpc_status to temporalio.service.RPCError that now lets users get the gRPC status including the Any details containing https://github.com/temporalio/api/tree/master/temporal/api/errordetails/v1 info
  • Update replayer docs w/ proper JSON load and multi-replay info

Checklist

  1. Closes [Bug] Replayer README inaccurate #212
  2. Closes [Feature Request] RPC error improvements #214
  3. Closes [Feature Request] Disallow cross-namespace child workflow calls #218

@cretz cretz requested a review from a team December 5, 2022 16:11
@cretz cretz marked this pull request as ready for review December 5, 2022 17:40
Sushisource
Sushisource approved these changes Dec 5, 2022
View reviewed changes
README.md
This will throw an error if any non-determinism is detected.

Replaying from workflow history is a powerful concept that many use to test that workflow alterations won't cause
non-determinisms with past-complete workflows. The following code will make sure that all workflow histories for a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
non-determinisms with past-complete workflows. The following code will make sure that all workflow histories for a
non-determinism errors with past-complete workflows. The following code will make sure that all workflow histories for a

@cretz cretz merged commit 06828ea into temporalio:main Dec 5, 2022
@cretz cretz deleted the general1 branch December 5, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Disallow cross-namespace child workflow calls [Feature Request] RPC error improvements [Bug] Replayer README inaccurate

2 participants

@cretz @Sushisource