Skip to content

Conversation

dnnsthnnr
Copy link
Contributor

What was changed

Added support for 3.10 / PEP 604 union annotations in the format of int | str.

Why?

Closes #255

Checklist

  1. Closes [Bug] PEP 604 style optionals not working properly #255

  2. How was this tested:
    Tests for the JSON converter for the PEP 604 annotations have been added and the tests actions passed on my clones repository for 3.11 and 3.7

  3. Any docs updates needed?

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If/when CI completes, I'll merge.

@cretz cretz merged commit f22efea into temporalio:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] PEP 604 style optionals not working properly

3 participants