Skip to content

Minor fixes #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 8, 2023
Merged

Minor fixes #268

merged 6 commits into from
Feb 8, 2023

Conversation

cretz
Copy link
Member

@cretz cretz commented Feb 7, 2023

What was changed

  • Update black and isort (this is what caused all those proto files to be updated, can mostly ignore)
  • Update MyPy (had to ignore some types and fix others)
  • Add minor fix for with_child_unrestricted sandbox call
  • Support contextvars in threaded activities

Checklist

  1. Closes [Bug] with_child_unrestricted not properly removing restriction #254
  2. Closes [Feature Request] Populate contextvars for threaded activities #263

@cretz cretz requested a review from a team February 7, 2023 15:20
@cretz cretz marked this pull request as ready for review February 7, 2023 15:52
@cretz cretz merged commit 3c8ee0a into temporalio:main Feb 8, 2023
@cretz cretz deleted the minor-fixes branch February 8, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Populate contextvars for threaded activities [Bug] with_child_unrestricted not properly removing restriction

2 participants

@cretz @Quinn-With-Two-Ns