Change types-protobuf dependency spec to match protobuf #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cretz
approved these changes
Feb 15, 2023
| [[package]] | ||
| name = "types-protobuf" | ||
| version = "3.20.3" | ||
| version = "4.21.0.6" |
There was a problem hiding this comment.
I wasn't sure we should also do the upgrade here, but seeing as how we do it for protobuf in the lock file this makes plenty of sense
There was a problem hiding this comment.
I believe it doesn't really matter, this lockfile should only affect you as a library developer and not the end users.
Also in its current state it's incosistent, since protobuf types don't match protobuf itself, which is I guess incorrect.
So I don't see a reason to not doing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #277