Skip to content

Conversation

cretz
Copy link
Member

@cretz cretz commented Mar 27, 2023

What was changed

Properly call JSON type converters recursively. Also fixate the Poetry version in CI due to Poetry bug.

Checklist

  1. Closes [Bug] JSONTypeConverter not applied recursively #289

@cretz cretz requested a review from a team March 27, 2023 16:32
@cretz cretz marked this pull request as draft March 27, 2023 16:41
@cretz
Copy link
Member Author

cretz commented Mar 27, 2023

Converting to draft while I fix CI

EDIT: Fixed. Yet another Poetry issue.

@cretz cretz marked this pull request as ready for review March 27, 2023 17:28
@cretz cretz merged commit d790468 into temporalio:main Mar 30, 2023
@cretz cretz deleted the recursive-json-converter branch March 30, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] JSONTypeConverter not applied recursively

2 participants