Update core/tonic, update metric options, remove core tracing #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| #[derive(FromPyObject)] | ||
| pub struct TelemetryConfig { | ||
| tracing: Option<TracingConfig>, |
There was a problem hiding this comment.
Is there a reason we are removing rather then say deprecating an treating it as unused?
There was a problem hiding this comment.
Removed as part of temporalio/sdk-core#599 which didn't work anyways and, based on internal discussions, was a rarely used advanced core debug tracer that we wanted to remove instead of deprecate.
Quinn-With-Two-Ns
approved these changes
Aug 28, 2023
Sushisource
approved these changes
Aug 28, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
temporalio.runtime.TelemetryConfig.tracingand associated classChecklist