Skip to content

Conversation

Sushisource
Copy link
Member

What was changed

Make updates get run through data converters

Why?

Kind of important. Maybe people want to encrypt stuff.

Checklist

  1. Closes [Bug] Updates not run through data converters #477

  2. How was this tested:
    Added updates to custom encoder test

  3. Any docs updates needed?

@Sushisource Sushisource requested a review from a team as a code owner February 22, 2024 23:20
Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unclear to me where the assertions happen but the code LGTM.

@Sushisource Sushisource merged commit f31f927 into main Feb 23, 2024
@Sushisource Sushisource deleted the encode-update-payloads branch February 23, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Updates not run through data converters

2 participants