Skip to content

Remove activity info retry policy #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2022
Merged

Remove activity info retry policy #65

merged 2 commits into from
Jul 13, 2022

Conversation

cretz
Copy link
Member

@cretz cretz commented Jul 6, 2022

What was changed

  • Remove activity.info().retry_policy
  • Cleanup other activity info timedelta values

Why?

  • The retry policy that comes from the server for activity tasks is not the one passed in when executing the activity
  • Durations coming back from Core are unfortunately present-but-zero for not-present timeouts

Checklist

  1. Closes [Bug] retry_policy not availably in activity info #62

@cretz cretz requested a review from a team July 6, 2022 14:01
@cretz cretz marked this pull request as ready for review July 6, 2022 15:16
@cretz cretz merged commit 7456f44 into temporalio:main Jul 13, 2022
@cretz cretz deleted the remove-activity-retry-policy branch July 13, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergundy bergundy bergundy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] retry_policy not availably in activity info

2 participants

@cretz @bergundy