Fix return type of workflow.wait #650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
commented
Sep 24, 2024
| raise TypeError(f"Expect an iterable of Tasks/Futures, not {type(fs).__name__}") | ||
| if not fs: | ||
| raise ValueError("Set of Tasks/Futures is empty.") | ||
| raise ValueError("Sequence of Tasks/Futures must not be empty.") |
There was a problem hiding this comment.
This check doesn't actually make sense, since the input could be an empty generator, which is truthy, but will become empty when materialized as a list below. Leaving for now since this is copied from cPython.
There was a problem hiding this comment.
👍 If they Python authors were better, it'd be below fs = list(fs) heh
cretz
approved these changes
Sep 25, 2024
dandavison
force-pushed
the
fix-wait-type
branch
from
67641a9 to
ceccf76
Compare
dandavison
force-pushed
the
fix-wait-type
branch
from
ceccf76 to
4f60288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the return type, and improve the comments inherited from Python a bit more.