Skip to content

Tracing #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Tracing #668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions temporalio/worker/_workflow_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
cast,
)

from google.protobuf.json_format import MessageToJson
from opentelemetry import trace
from typing_extensions import Self, TypeAlias, TypedDict

import temporalio.activity
Expand Down Expand Up @@ -75,6 +77,7 @@
)

logger = logging.getLogger(__name__)
tracer = trace.get_tracer(__name__)

# Set to true to log all cases where we're ignoring things during delete
LOG_IGNORE_DURING_DELETE = False
Expand Down Expand Up @@ -325,6 +328,21 @@ def get_thread_id(self) -> Optional[int]:

def activate(
self, act: temporalio.bridge.proto.workflow_activation.WorkflowActivation
) -> temporalio.bridge.proto.workflow_completion.WorkflowActivationCompletion:
with tracer.start_as_current_span("HandleWorkflowActivation") as span:
span.set_attribute("rpc.method", "WorkflowActivation")
span.set_attribute("rpc.request.type", "WorkflowActivation")
span.set_attribute("rpc.request.payload", MessageToJson(act))
span.set_attribute("temporalWorkflowID", self._info.workflow_id)
span.set_attribute("temporal.worker", True)
completion = self._activate(act)
span.set_attribute("rpc.response.type", "WorkflowActivationCompletion")
span.set_attribute("rpc.response.payload", MessageToJson(completion))
trace.get_tracer_provider().force_flush() # type: ignore
return completion

def _activate(
self, act: temporalio.bridge.proto.workflow_activation.WorkflowActivation
) -> temporalio.bridge.proto.workflow_completion.WorkflowActivationCompletion:
# Reset current completion, time, and whether replaying
self._current_completion = (
Expand Down
Loading