Additional high-level describe details #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
reviewed
Jul 13, 2022
| close_time: Optional[datetime] | ||
| execution_time: Optional[datetime] | ||
| history_length: int | ||
| id: str |
There was a problem hiding this comment.
This should probably be workflow_id. It's that way in TS and you have to infer what it is by looking at run id and knowing there are two types of IDs, which seems less than ideal.
There was a problem hiding this comment.
In Python we have used id where it's obviously a workflow ID to avoid stuttering and unnecessary typing. So we have WorkflowHandle.id, start_workflow(id="myid") etc. This was how it was originally proposed/designed, but if we want to change all of these we can (I'd do it in a separate PR). I will bring it up.
bergundy
reviewed
Jul 13, 2022
bergundy
reviewed
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add the same high-level workflow execution description properties that TS has
Why?
Raw message is too cumbersome