More precise logging in CI #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Jan 16, 2025
I'd say so. Maybe it wasn't as bad in the early days of the repo. |
dandavison
force-pushed
the
more-precise-ci-logging
branch
from
44a54da to
16855fa
Compare
dandavison
force-pushed
the
more-precise-ci-logging
branch
from
16855fa to
9cbf307
Compare
cretz
approved these changes
Jan 16, 2025
Comment on lines
-108
to
+111
| log_cli = true | ||
| log_cli_level = "INFO" | ||
| log_cli_format = "%(asctime)s [%(levelname)8s] %(message)s (%(filename)s:%(lineno)s)" | ||
| # Do not use log_cli since this shows logging for all tests, not just the ones | ||
| # that failed. Instead, show all logs for failed tests at the end. | ||
| log_level = "DEBUG" | ||
| log_format = "%(asctime)s [%(levelname)8s] %(message)s (%(filename)s:%(lineno)s)" |
There was a problem hiding this comment.
Near the bottom of the README there is:
For example, here's how to run a single test with debug logs on the console:
poe test -s --log-cli-level=DEBUG -k test_sync_activity_thread_cancel_caughtI admit I use this a lot during development on passing tests (I put this at the bottom of the README on .NET and Ruby too because I forget the args going from one to the other). Will this still work or does this need to be updated now to enable CLI logging?
There was a problem hiding this comment.
That still works:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, CI test logs should:
Make it easy to see which tests have failed
Help understand how they have failed
To that end, they should:
Include minimal output for tests that pass
Include full output for tests that fail (should not be many)
Previously we were using pytest's
log-clifeature, which outputs logs for all tests as the tests are run. This PR stops using that, instead switching to a config that outputs all logging output >= DEBUG for failed tests, at the end of the test run (search for=================================== FAILURES ===================================).See https://docs.pytest.org/en/stable/how-to/logging.html#logging.