Skip to content

Do not include self parameter in handlers in test #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Do not include self parameter in handlers in test #746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tests/worker/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
ApplicationError,
CancelledError,
ChildWorkflowError,
FailureError,
TemporalError,
TimeoutError,
WorkflowAlreadyStartedError,
Expand Down Expand Up @@ -5547,25 +5546,25 @@ async def run(
if handler_dynamism == "-dynamic-":

async def my_late_registered_dynamic_update(
self, name: str, args: Sequence[RawValue]
name: str, args: Sequence[RawValue]
) -> str:
await workflow.wait_condition(lambda: self.handlers_may_finish)
return "my-late-registered-dynamic-update-result"

async def my_late_registered_dynamic_signal(
self, name: str, args: Sequence[RawValue]
name: str, args: Sequence[RawValue]
) -> None:
await workflow.wait_condition(lambda: self.handlers_may_finish)

workflow.set_dynamic_update_handler(my_late_registered_dynamic_update)
workflow.set_dynamic_signal_handler(my_late_registered_dynamic_signal)
else:

async def my_late_registered_update(self) -> str:
async def my_late_registered_update() -> str:
await workflow.wait_condition(lambda: self.handlers_may_finish)
return "my-late-registered-update-result"

async def my_late_registered_signal(self) -> None:
async def my_late_registered_signal() -> None:
await workflow.wait_condition(lambda: self.handlers_may_finish)

workflow.set_update_handler(
Expand Down
Loading