Add a workflow level check for the existence of a local activity #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cretz
reviewed
May 8, 2025
cretz
reviewed
May 8, 2025
cretz
approved these changes
May 8, 2025
Co-authored-by: Chad Retz <[email protected]>
tconley1428
force-pushed
the
missing_local_activity
branch
from
ac5042e to
041c0e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Attempting to execute a local activity which does not exist will fail the workflow task.
Why?
Additional retries of the activity will not change the outcome.
Checklist
Closes [Bug] Missing Local Activites should fail WFT rather than retry-looping #845
How was this tested:
New tests in test_workflow.py
Any docs updates needed?
No