Skip to content

Conversation

@cretz
Copy link
Member

@cretz cretz commented Jul 25, 2022

What was changed

  • Accept target_host now that is just host:port instead of full URL
  • Update Temporalite and fix TLS tests

Checklist

  1. Closes Accept host:port for client instead of only URL #79

@cretz cretz requested a review from a team July 25, 2022 22:01
temporalio.common.QueryRejectCondition
] = None,
tls_config: Optional[TLSConfig] = None,
tls: Union[bool, TLSConfig] = False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider accepting None here too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems ambiguous. We used to accept None here when this wasn't how you chose whether TLS is used, but now a tls=False is clearer. The parameter changed from "tls configuration" to "tls enabled, with configuration if necessary".

Copy link
Member

@bergundy bergundy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you eventually going to remove the go SDK dependency from here?

@cretz
Copy link
Member Author

cretz commented Jul 26, 2022

Are you eventually going to remove the go SDK dependency from here?

Yes, but while I continue to have to build Temporalite which has a Go dependency too, I am in no hurry. If Temporalite binaries were released standalone I would remove Go completely from the test process. I have opened temporalio/temporalite-archived#94.

@cretz
Copy link
Member Author

cretz commented Jul 26, 2022

Hrmm, the upgrade of Temporalite to 1.17.x is causing an issue with start-then-immediate-query from temporalio/temporal#2826. I am talking with @yiminc and the server team. I may have to downgrade or alter code to ignore FailedPrecondition.

EDIT: Altered code to fix this

@cretz cretz merged commit 2288f41 into temporalio:main Aug 1, 2022
@cretz cretz deleted the host-port branch August 1, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept host:port for client instead of only URL

2 participants